Skip to content

Allow connection for devices that don't have SNI mapping_detect implemented #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awardjr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow connection for devices that don't have SNI mapping_detect implemented #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab20cf7
If SNI mapping_detect isn't implemented and we recieve a strucutred u…
awardjr May 31, 2026
2513c71
Revert my editor's line length opinion
awardjr May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions EmoTracker/Providers/SNI/SniDevice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Grpc.Core;

namespace EmoTracker.Providers.SNI
{
Expand Down Expand Up @@ -84,6 +85,16 @@ public override async Task ConnectAsync()
mConnected = true;
ConnectionStatusChanged?.Invoke(this, true);
}
catch (RpcException ex)
{
//SNI Memory Mapping Detection isn't implemented for these devices, but we are connected if we're getting this response
if(ex.StatusCode == StatusCode.Unimplemented)
Log.Debug("[SNI] Device does not implement mapping_detect however we are connected as we " +
"explicitly received the Unimplemented status {DisplayName}: {Message}",
mDisplayName, ex.Message);
mConnected = true;
ConnectionStatusChanged?.Invoke(this, true);
}
catch (Exception ex)
{
Log.Warning("[SNI] Failed to connect to {DisplayName}: {Message}", mDisplayName, ex.Message);
Expand Down
Loading