Allow connection for devices that don't have SNI mapping_detect implemented#99
Open
awardjr wants to merge 2 commits into
Open
Allow connection for devices that don't have SNI mapping_detect implemented#99awardjr wants to merge 2 commits into
awardjr wants to merge 2 commits into
Conversation
…nimplemented status, assume the device is connected.
emosaru
approved these changes
May 31, 2026
Contributor
emosaru
left a comment
emosaru
left a comment
There was a problem hiding this comment.
I'm approving this review, but am holding off on submitting it for a bit pending further discussion in Discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some SNI distributions, such as the currently in testing MiSTerFPGA implementation, the SNI mapping_detect functionality is not implemented. See: https://github.com/NobodyNada/snid/blob/530b1ad2a9a29219ba0431f1c8ddee14cc61c286/src/server/sni/mod.rs#L173
When we receive a well formed error with the status explicitly "Unimplemented," we can assume the device is connected for users of said devices. However, they will have to know to explicitly change the Memory Mapping if their game requires until mapping_detect is implemented, if possible.
Tested with Map Rando on a MiSTerFPGA, and this implementation was done in a way that hopefully won't cause any issues with other already tested platforms