Rework scope collection serialization#256
Draft
gwen-lg wants to merge 8 commits intoEmbarkStudios:mainfrom
Draft
Rework scope collection serialization#256gwen-lg wants to merge 8 commits intoEmbarkStudios:mainfrom
gwen-lg wants to merge 8 commits intoEmbarkStudios:mainfrom
Conversation
use DataHeader this prepare serialization of scope collection
Contributor
Author
|
@emilk : not sure if you see this, as it's a draft. |
This was referenced Aug 25, 2025
bump file magic to `PUF1`
gwen-lg
force-pushed
the
rework_scope_collection_serialization
branch
from
612a20e to
a84d3ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as the code need check and clean. But advanced enough to have feedback on the intention.
Checklist
Description of Changes
Add a specific (de)serialization of
ScopeCollection(independent ofFrameDataserialization).This is done to avoid but and improve readability of the code.
This simplify the code by avoid mixed usage of serialized scopes of
FrameDatafor scope_collection or delta_scope.b"PUF1".puffin_httpprotocol version to3.b"PSC1".Related Issues