Puffin_http: Add wait client feature#257
Draft
gwen-lg wants to merge 3 commits intoEmbarkStudios:mainfrom
Draft
Conversation
use Arc RwLock container to share clients list
use a rendez-vous channel this could be useful for issues EmbarkStudios#85 and EmbarkStudios#172
d0f0642 to
9938819
Compare
Contributor
|
Hi! I am interested in this feature so I decided to review your changes. Here is what I have found:
Also, I think that there are some usability issues with the new API:
I would prefer this functionality in a form of two callback functions: |
3 tasks
Contributor
|
I tried to implement this on my own: #264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as it's should be better to finish and merge #256 first.
And the preparation changes need to be cleaned.
Checklist
Description of Changes
Add a
wait_client()function onpuffin_http::Serverto be able to pause profiled application while the client (ex: puffin_viewer) is connected.This allow to avoid to lost first frames.
Move accept_new_clients() out of the frame reception loop and in is own thread, otherwise it won't work.
Related Issues
List related issues here