Skip to content

Update dependencies #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcImberger wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update dependencies #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41c5b2d
Fix xarray dependency version specification
MarcImberger Nov 27, 2025
7b04a65
Update Python versions in CI workflow
MarcImberger Nov 27, 2025
230bb97
Update Python version requirements in pyproject.toml
SchmJo Nov 27, 2025
921348b
Add Python 3.9 to the test matrix
SchmJo Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
View file
Open in desktop
Copy link
Contributor

@SchmJo SchmJo Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.9 is supported to my knowledge - I tested the installation locally on my computer, and also during testing the installation works

Copy link
Author

@MarcImberger MarcImberger Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was more thinking about the end-of-live of python 3.9 (no need to support it anymore or make things backwards compatible)

Copy link
Contributor

@SchmJo SchmJo Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is also a good point. I will discuss this with the team, thanks. My personal philosophy is to drop deprecated Python versions as soon as they cause trouble

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 4 additions & 3 deletions pyproject.toml
View file
Open in desktop
Copy link
Contributor

@SchmJo SchmJo Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Python version to >=3.9,<3.14 such that it now includes 3.12 and 3.13. But 3.9 also seems to be supported, according to my testing

Copy link
Member

@kilojoules kilojoules Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep testing 3.9 until it breaks

Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,19 @@ classifiers = [
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Development Status :: 3 - Alpha",
]
requires-python = ">=3.9,<3.12"
requires-python = ">=3.9,<3.14"
Copy link
Member

@kilojoules kilojoules Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good provided we can pass tests in these python envs

dependencies = [
"py_wake>=2.6.5",
"foxes>=1.6.2",
"windIO @ git+https://github.com/EUFlow/windIO.git",
"wayve @ git+https://gitlab.kuleuven.be/TFSO-software/wayve@dev_foxes",
#"numpy<2",
"xarray>=2022.0.0,<2025",
"xarray>=2022.0.0",
"mpmath",
]

Expand Down
Loading