Conversation
|
Thanks for this, I removed the Python version limit in the pyproject.toml as well |
|
The tests fail due to another issue, discussed in #32 |
There was a problem hiding this comment.
python 3.9 is supported to my knowledge - I tested the installation locally on my computer, and also during testing the installation works
There was a problem hiding this comment.
Ah, I was more thinking about the end-of-live of python 3.9 (no need to support it anymore or make things backwards compatible)
There was a problem hiding this comment.
Oh, that is also a good point. I will discuss this with the team, thanks. My personal philosophy is to drop deprecated Python versions as soon as they cause trouble
There was a problem hiding this comment.
I updated the Python version to >=3.9,<3.14 such that it now includes 3.12 and 3.13. But 3.9 also seems to be supported, according to my testing
There was a problem hiding this comment.
Let's keep testing 3.9 until it breaks
|
LGTM. Let's merge main in to this branch before we merge this into main. All tests must pass before we merge. |
There was a problem hiding this comment.
Let's keep testing 3.9 until it breaks
| "Development Status :: 3 - Alpha", | ||
| ] | ||
| requires-python = ">=3.9,<3.12" | ||
| requires-python = ">=3.9,<3.14" |
There was a problem hiding this comment.
sounds good provided we can pass tests in these python envs
3 participants
Drop unsupported python 3.9, add 3.12 and 3.13, remove cap on xarray