Add unit test for IEnumerable handling in Engine node validation#16888
Closed
Copilot wants to merge 4 commits intosaintentropy-patch-1from
Closed
Add unit test for IEnumerable handling in Engine node validation#16888Copilot wants to merge 4 commits intosaintentropy-patch-1from
Copilot wants to merge 4 commits intosaintentropy-patch-1from
Conversation
Co-authored-by: QilongTang <3942418+QilongTang@users.noreply.github.com>
Co-authored-by: QilongTang <3942418+QilongTang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug with Engine node
Add unit test for IEnumerable handling in Engine node validation
Feb 11, 2026
Contributor
|
@saintentropy @mjkkirschner I asked agent to add unit test for your other PR, PTAL |
|
Contributor
|
@copilot Rebase |
Contributor
Author
The rebase has been completed successfully. The branch has been rebased onto the latest
The force push will need to be completed manually or the GitHub Actions permissions may need to be adjusted to allow the push. |
Copilot stopped work on behalf of
QilongTang due to an error
April 9, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Engine node's
IsSupportedDataNodeDynamoTypemethod was recently fixed to acceptIEnumerableinstead of onlyArrayList, sinceParseJSONreturnsIEnumerable<object>. This PR adds comprehensive unit test coverage for that fix.Test Coverage
The new test
IsSupportedDataNodeDynamoType_HandlesIEnumerableFromParseJSON()verifies:IEnumerablecollections fromParseJSONare validated correctly as listsIEnumerabletreatment (critical edge case - strings implementIEnumerable<char>)IEnumerableimplementations (List<T>, parsed JSON arrays) work consistently💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.