Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Engine node where list data validation was failing due to an incorrect type check. The node was checking for ArrayList specifically, but values serialized through ParseJSON(playerValue) via the Player do not return ArrayList instances, causing valid list data to be incorrectly rejected.
Key Changes:
- Updated type check from
ArrayListtoIEnumerableto support all enumerable collections
|
Is this PR aiming for 4.0 release or 4.1? Curious if there is a Jira task |
|
4.1 I think @QilongTang |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot Help me create a unit test on this code change |
|
@QilongTang I've opened a new pull request, #16888, to work on those changes. Once the pull request is ready, I'll request review from you. |
|



Purpose
The Graph Engine node is failing in some circumstances due to incorrect check. Currently the values pushed to DefineData via Player are serialized via
ParseJSON(playerValue);which does not return anArrayList.Declarations
Check these if you believe they are true
Release Notes
Engine node bug is fixed for supporting list data.
Reviewers
@twastvedt
FYIs