Skip to content

Fix "Edit this page" URL not updating on soft navigation #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ealmloff merged 1 commit into from
Mar 10, 2026
Merged

Fix "Edit this page" URL not updating on soft navigation #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/docsite/src/components/learn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,8 @@ pub fn RightNav<R: AnyBookRoute>() -> Element {
let page = R::use_route();
let short_version = R::short_version();

let page_url = use_memo(move || page.to_string());

let edit_github_url = use_resource(move || async move {
let page = page_url();
let edit_github_url = use_resource(use_reactive!(|(page,)| async move {
let page = page.to_string();
let page_without_hash = page.split_once("#").map(|(url, _)| url).unwrap_or(&page);
let page_without_query = page_without_hash
.split_once("?")
Expand All @@ -274,7 +272,7 @@ pub fn RightNav<R: AnyBookRoute>() -> Element {
} else {
format!("{GITHUB_EDIT_PAGE_EDIT_URL}{short_version}/src{page_without_query}.md")
}
});
}));

// That might be a naive approach, but it's the easiest
rsx! {
Expand Down