Fix "Edit this page" URL not updating on soft navigation#635
Merged
ealmloff merged 1 commit intoDioxusLabs:mainfrom Mar 10, 2026
Merged
Conversation
The edit_github_url resource in RightNav was never re-running on route changes because page (a plain Copy value) was captured by value into use_memo, giving the memo no reactive dependencies. Replace use_memo + use_resource with use_resource(use_reactive!(...)) so the resource re-runs whenever page changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RightNavwas stuck on the URL from the initial page load and never updated during client-side (soft) navigation.page(a plainCopyvalue fromR::use_route()) was captured by value into ause_memoclosure, giving the memo no reactive dependencies. Since the memo never re-evaluated, theuse_resourcethat depended on it also never re-ran.use_memoand useuse_resource(use_reactive!(|(page,)| ...))so the resource re-runs whenever the route changes.Test plan