Skip to content

fix: additional new line in info.plist #5389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 2 commits into from
Mar 27, 2026
+1 −2
Merged

fix: additional new line in info.plist #5389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66fb509
fix: additional new line in info.plist
javiersuweijie Mar 19, 2026
e97049a
Merge remote-tracking branch 'origin/main' into fix/info-plist-new-line
jkelleyrtp Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/cli/src/build/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7049,8 +7049,7 @@ We checked the folders:
};

let entitlements_xml = format!(
r#"
<?xml version="1.0" encoding="UTF-8"?>
r#"<?xml version="1.0" encoding="UTF-8"?>
Comment on lines 7051 to +7052
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the code path that actually writes iOS Info.plist

For the default iOS build path, this change only alters auto_provision_entitlements(), and that string is written to a temporary entitlements file for codesigning (packages/cli/src/build/request.rs:6510-6523), not to the bundled Info.plist. The app’s Info.plist is still produced by info_plist_contents() and the unchanged packages/cli/assets/ios/ios.plist.hbs template (packages/cli/src/build/request.rs:4893-4896, 5398-5401), so the first-line newline bug reported in #5387 will still reproduce for users who rely on the generated plist.

Useful? React with 👍 / 👎.

<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"><dict>
<key>application-identifier</key>
Expand Down