fix: additional new line in info.plist#5389
fix: additional new line in info.plist#5389javiersuweijie wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66fb509654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let entitlements_xml = format!( | ||
| r#" | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| r#"<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
For the default iOS build path, this change only alters auto_provision_entitlements(), and that string is written to a temporary entitlements file for codesigning (packages/cli/src/build/request.rs:6510-6523), not to the bundled Info.plist. The app’s Info.plist is still produced by info_plist_contents() and the unchanged packages/cli/assets/ios/ios.plist.hbs template (packages/cli/src/build/request.rs:4893-4896, 5398-5401), so the first-line newline bug reported in #5387 will still reproduce for users who rely on the generated plist.
Useful? React with 👍 / 👎.
1 participant
This fixes: #5387
There is an additional new line that breaks some downstream applications that do not trim the XML before parsing it.