Skip to content

Fix: notify parent store when child is marked dirty #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ealmloff merged 5 commits into from
Apr 10, 2026
+742 −90
Merged

Fix: notify parent store when child is marked dirty #5365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4daecb8
add tests
dunkyl Mar 12, 2026
873998a
fix: include root node when store is marked dirty
dunkyl Mar 12, 2026
5cdd103
Merge branch 'DioxusLabs:main' into dirty-parent-stores
dunkyl Apr 8, 2026
9e72d9b
fix tracking deep subscriptions. We need to walk all parents for deep…
ealmloff Apr 9, 2026
9edc251
avoid double notifying parents when children re-visit parents in deep…
ealmloff Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/stores/src/scope.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ impl<Lens> SelectorScope<Lens> {

/// Track this scope recursively.
pub fn track(&self) {
self.store.track_recursive(&self.path);
self.store.track_deep(&self.path);
}

/// Mark this scope as dirty recursively.
Expand All @@ -161,7 +161,7 @@ impl<Lens> SelectorScope<Lens> {

/// Mark this scope as dirty shallowly.
pub fn mark_dirty_shallow(&self) {
self.store.mark_dirty_shallow(&self.path);
self.store.mark_node_dirty(&self.path);
}

/// Mark this scope as dirty at and after the given index.
Expand Down Expand Up @@ -210,7 +210,7 @@ impl<Lens: Readable> Readable for SelectorScope<Lens> {
}

fn subscribers(&self) -> Subscribers {
self.store.subscribers(&self.path)
self.store.shallow_subscribers(&self.path)
}
}

Expand Down
Loading
Loading