Fix: notify parent store when child is marked dirty#5365
Open
dunkyl wants to merge 2 commits intoDioxusLabs:mainfrom
Open
Fix: notify parent store when child is marked dirty#5365dunkyl wants to merge 2 commits intoDioxusLabs:mainfrom
dunkyl wants to merge 2 commits intoDioxusLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #5363
Too easy to be real?
In practice, I was able to point my more complex app at this PR and its behavior was fixed. I tried to also include some tests to cover basic behavior (do writes spread down, up, and not to siblings?). The additional dev dependencies are for testing convenience.
What I am most unsure about is if
StoreSubscriptionsis the correct place for this fix, if it might need to instead be moved up intoSelectorScope, or if it should be moved down intoSelectorNode.