-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/auth #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/auth #44
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
56f5341
feat: redirection 처리 구현
liveforpresent 0d8b1c0
fix: 로그인 시 유저 id 반환하도록 수정
liveforpresent b1227cc
fix: 콜백함수 http 방식 post로 수정
liveforpresent 356adb4
feat: DB에서 auth 조회 전용 도메인 객체 생성 함수 구현
liveforpresent faf3303
fix: 프론트에서 redirectPath 지정할 수 있도록 수정
liveforpresent 322e2b7
fix: 변수명 수정
liveforpresent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
src/auth/application/authorize-oauth/dto/authorize-oauth.request.dto.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| import { IsEnum, IsNotEmpty } from 'class-validator'; | ||
| import { IsEnum, IsNotEmpty, IsString } from 'class-validator'; | ||
| import { OAuthProviderType } from 'src/auth/domain/value-object/oauth-provider.enum'; | ||
|
|
||
| export class AuthorizeOAuthRequestDto { | ||
| @IsEnum(OAuthProviderType) | ||
| @IsNotEmpty() | ||
| oAuthProviderType: OAuthProviderType; | ||
|
|
||
| @IsString() | ||
| redirectUrl?: string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POST로 바꾸면 provider의 리디렉션이 컨트롤러에 도달하지 않아서 GET으로 유지해야 한다는데, 저도 확실치가 않아서 확인 한 번만 해주세요.
추가적으로 클라이언트가 제공하는 redirectUrl을 그대로 사용하기 보다는 이것에 대한 whitelist 또는 도메인 검사로 검증해서 보안을 좀 강화시키는 것도 좋을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.