Feature/auth #44
Merged
Feature/auth #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunwoo611
reviewed
Oct 30, 2025
| } | ||
|
|
||
| @Get('login/oauth/callback') | ||
| @Post('login/oauth/callback') |
Contributor
There was a problem hiding this comment.
POST로 바꾸면 provider의 리디렉션이 컨트롤러에 도달하지 않아서 GET으로 유지해야 한다는데, 저도 확실치가 않아서 확인 한 번만 해주세요.
추가적으로 클라이언트가 제공하는 redirectUrl을 그대로 사용하기 보다는 이것에 대한 whitelist 또는 도메인 검사로 검증해서 보안을 좀 강화시키는 것도 좋을 것 같아요.
Contributor
Author
There was a problem hiding this comment.
- 로그인 트리거(/oauth/authorize)와 콜백(login/oauth/callback)을 분리해서 프론트에서 직접 콜백을 요청하는 방식으로 변경해서 문제 없이 진행돼요.
- 로직 추가하겠니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용