Skip to content

ECHO-673 directus whitelabel folder fix#447

Merged
ussaama merged 1 commit intomainfrom
testing
Feb 16, 2026
Merged

ECHO-673 directus whitelabel folder fix#447
ussaama merged 1 commit intomainfrom
testing

Conversation

@ussaama
Copy link
Contributor

@ussaama ussaama commented Feb 16, 2026

Summary by CodeRabbit

  • Chores
    • Updated folder collection configuration structure to streamline folder management and remove unused entries.

@linear
Copy link

linear bot commented Feb 16, 2026

ECHO-673 fixes

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The folders.json sync configuration was consolidated, removing four entries (two "custom_logos" and one "Public" folder) down to two folder entries. The remaining entries maintain their _syncId, name, and parent field structure with adjusted key ordering. Net change: +10/-20 lines.

Changes

Cohort / File(s) Summary
Sync Configuration
echo/directus/sync/collections/folders.json
Reduced folder entries from 4 to 2 by removing custom_logos duplicates and Public folder; reordered object key fields in remaining entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR modifies directus folder configuration but linked issue ECHO-673 focuses on UI elements (icons, logos, backgrounds, auto-save) unrelated to folder structure. Verify the PR addresses the correct issue. The folder JSON changes don't implement any of ECHO-673's UI/UX requirements. Either update the linked issue or confirm this is a follow-up task.
Out of Scope Changes check ⚠️ Warning The PR removes folder entries from directus sync configuration, which appears unrelated to the UI/icon/logo changes specified in ECHO-673. Clarify the relationship between folder structure changes and whitelabel UI fixes. The folder modification seems out of scope for the stated objectives.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title references ECHO-673 issue and mentions directus whitelabel folder fix, directly correlating to the JSON configuration changes in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch testing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ussaama ussaama merged commit 7d3c526 into main Feb 16, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant