Remove unnecessary Option from assembly::fragments#151
Merged
Conversation
1065e5a to
b8305c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the
Option<_>part ofassembly::fragments's return type and the correspondingSome/Nonecheck inassembly::recurse_index_search.In #121, we updated match enumeration to use the DAG approach from Seet et al. (2025). Specifically, we implemented
matches::matches_to_removewhich uses the DAG to determine the list of matches that can be removed from a given assembly state. Thus, it is now impossible forassembly::fragmentsto ever returnNone, as this would indicate a match cannot be found among an assembly state's fragments.Benchmarks show this is a performance-neutral change; the rare improvements/regressions seem to be noise.
Benchmark b8305c8 (this PR) vs. e7ca3d4 (current main) as a baseline