Frontend Docker overhaul: multi-stage build and RUM env cleanup#183
Open
briannadelvalle-datadog wants to merge 1 commit into
Open
Frontend Docker overhaul: multi-stage build and RUM env cleanup#183briannadelvalle-datadog wants to merge 1 commit into
briannadelvalle-datadog wants to merge 1 commit into
Conversation
Wire the frontend service to its multi-stage Dockerfile (dev uses target: development) and enable standalone Next.js output for the production build. Standardize the frontend's Datadog RUM env vars on the NEXT_PUBLIC_DD_* naming in both compose files and drop the now obsolete wait-for-it/FRONTEND_COMMAND startup indirection. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
There was a problem hiding this comment.
This just cleans up console logs. Removed getRandomArbitrary, because it's unclear what purpose it served.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f## Summary
Dockerfile(dev usestarget: development) and enablesstandaloneNext.js output for production.NEXT_PUBLIC_DD_*in both compose files and drops the obsoletewait-for-it/FRONTEND_COMMANDstartup indirection (removed from.env.template).Adcomponent; addsservices/frontend/CHANGELOG.mdand a rootCHANGELOG.md.Stack
Part of the TRAIN-3546 split. Base:
main. The healthchecks PR stacks on top of this one.How to test
docker compose upand confirm frontend serves on :3000 with RUM configured.Note: The prod docker-compose will not work until a release is built (the
latestimage won't have the requiredserver.jsfile until then.)Made with Cursor