Replace wait-for-it with Docker Compose healthchecks#184
Open
briannadelvalle-datadog wants to merge 1 commit into
Open
Replace wait-for-it with Docker Compose healthchecks#184briannadelvalle-datadog wants to merge 1 commit into
briannadelvalle-datadog wants to merge 1 commit into
Conversation
Add healthcheck blocks to all services and convert depends_on to condition-based gating (service_healthy/service_started) in both compose files. Drop the wait-for-it package from the backend, ads (Python), and discounts Dockerfiles, adding netcat-openbsd where the healthcheck needs nc. Add a backend .dockerignore and source the Postgres credentials from the environment in database.yml. Also fix a "ddprofrb execrails" typo in the backend Dockerfile CMD. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
healthcheckblocks to all services and convertsdepends_onto condition-based gating (service_healthy/service_started) in both compose files.wait-for-itpackage from the backend, ads (Python), and discounts Dockerfiles, addingnetcat-openbsdwhere the healthcheck needsnc..dockerignoreand sources Postgres credentials from the environment indatabase.yml.ddprofrb execrailstypo in the backend Dockerfile CMD.CHANGELOG.mdfor backend/ads/discounts and updates the ads README compose example.Stack
Part of the TRAIN-3546 split. Base:
TRAIN-3546-frontend-docker-overhaul(shares the frontend compose block). Merge after #183.Test plan
docker compose upand confirm services become healthy and dependents start in order.Made with Cursor