-
Notifications
You must be signed in to change notification settings - Fork 319
Combine client_drop_p0s support and agent version check for CSS
#10046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bric3
merged 2 commits into
master
from
bdu/combine-p0drop-support-and-agent-version-check
Dec 10, 2025
Merged
Combine client_drop_p0s support and agent version check for CSS
#10046
bric3
merged 2 commits into
master
from
bdu/combine-p0drop-support-and-agent-version-check
Dec 10, 2025
+6
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
reviewed
Nov 27, 2025
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087644
Total [baseline] (10.855 s) : 0, 10854502
Agent [candidate] (1.078 s) : 0, 1078284
Total [candidate] (10.787 s) : 0, 10786604
section appsec
Agent [baseline] (1.259 s) : 0, 1259464
Total [baseline] (11.052 s) : 0, 11052120
Agent [candidate] (1.263 s) : 0, 1262918
Total [candidate] (11.153 s) : 0, 11153475
section iast
Agent [baseline] (1.222 s) : 0, 1222277
Total [baseline] (11.224 s) : 0, 11223749
Agent [candidate] (1.221 s) : 0, 1221079
Total [candidate] (11.1 s) : 0, 11100137
section profiling
Agent [baseline] (1.204 s) : 0, 1203501
Total [baseline] (11.176 s) : 0, 11175985
Agent [candidate] (1.2 s) : 0, 1200131
Total [candidate] (10.873 s) : 0, 10873478
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (652.842 ms) : 0, 652842
BytebuddyAgent [candidate] (646.881 ms) : 0, 646881
GlobalTracer [baseline] (283.085 ms) : 0, 283085
GlobalTracer [candidate] (280.917 ms) : 0, 280917
AppSec [baseline] (32.7 ms) : 0, 32700
AppSec [candidate] (32.284 ms) : 0, 32284
Debugger [baseline] (68.534 ms) : 0, 68534
Debugger [candidate] (68.017 ms) : 0, 68017
Remote Config [baseline] (653.665 µs) : 0, 654
Remote Config [candidate] (662.745 µs) : 0, 663
Telemetry [baseline] (9.136 ms) : 0, 9136
Telemetry [candidate] (9.04 ms) : 0, 9040
Flare Poller [baseline] (3.809 ms) : 0, 3809
Flare Poller [candidate] (3.832 ms) : 0, 3832
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (686.566 ms) : 0, 686566
BytebuddyAgent [candidate] (688.919 ms) : 0, 688919
GlobalTracer [baseline] (258.069 ms) : 0, 258069
GlobalTracer [candidate] (258.726 ms) : 0, 258726
AppSec [baseline] (174.307 ms) : 0, 174307
AppSec [candidate] (173.995 ms) : 0, 173995
Debugger [baseline] (65.874 ms) : 0, 65874
Debugger [candidate] (66.294 ms) : 0, 66294
Remote Config [baseline] (730.395 µs) : 0, 730
Remote Config [candidate] (693.023 µs) : 0, 693
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (9.111 ms) : 0, 9111
Flare Poller [baseline] (3.887 ms) : 0, 3887
Flare Poller [candidate] (3.901 ms) : 0, 3901
IAST [baseline] (24.36 ms) : 0, 24360
IAST [candidate] (24.542 ms) : 0, 24542
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (790.816 ms) : 0, 790816
BytebuddyAgent [candidate] (788.952 ms) : 0, 788952
GlobalTracer [baseline] (255.144 ms) : 0, 255144
GlobalTracer [candidate] (255.393 ms) : 0, 255393
AppSec [baseline] (35.288 ms) : 0, 35288
AppSec [candidate] (35.113 ms) : 0, 35113
Debugger [baseline] (65.388 ms) : 0, 65388
Debugger [candidate] (65.846 ms) : 0, 65846
Remote Config [baseline] (582.258 µs) : 0, 582
Remote Config [candidate] (614.365 µs) : 0, 614
Telemetry [baseline] (8.349 ms) : 0, 8349
Telemetry [candidate] (8.361 ms) : 0, 8361
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.46 ms) : 0, 3460
IAST [baseline] (26.809 ms) : 0, 26809
IAST [candidate] (26.903 ms) : 0, 26903
section profiling
ProfilingAgent [baseline] (98.498 ms) : 0, 98498
ProfilingAgent [candidate] (97.259 ms) : 0, 97259
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (699.07 ms) : 0, 699070
BytebuddyAgent [candidate] (699.184 ms) : 0, 699184
GlobalTracer [baseline] (221.144 ms) : 0, 221144
GlobalTracer [candidate] (219.812 ms) : 0, 219812
AppSec [baseline] (32.294 ms) : 0, 32294
AppSec [candidate] (32.02 ms) : 0, 32020
Debugger [baseline] (68.299 ms) : 0, 68299
Debugger [candidate] (67.788 ms) : 0, 67788
Remote Config [baseline] (663.782 µs) : 0, 664
Remote Config [candidate] (649.251 µs) : 0, 649
Telemetry [baseline] (9.116 ms) : 0, 9116
Telemetry [candidate] (8.987 ms) : 0, 8987
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.813 ms) : 0, 3813
Profiling [baseline] (99.088 ms) : 0, 99088
Profiling [candidate] (97.847 ms) : 0, 97847
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080764
Total [baseline] (8.751 s) : 0, 8751326
Agent [candidate] (1.075 s) : 0, 1075185
Total [candidate] (8.703 s) : 0, 8702856
section iast
Agent [baseline] (1.229 s) : 0, 1228729
Total [baseline] (9.443 s) : 0, 9442613
Agent [candidate] (1.22 s) : 0, 1220010
Total [candidate] (9.414 s) : 0, 9414292
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (649.107 ms) : 0, 649107
BytebuddyAgent [candidate] (645.726 ms) : 0, 645726
GlobalTracer [baseline] (281.229 ms) : 0, 281229
GlobalTracer [candidate] (280.541 ms) : 0, 280541
AppSec [baseline] (32.324 ms) : 0, 32324
AppSec [candidate] (32.19 ms) : 0, 32190
Debugger [baseline] (67.727 ms) : 0, 67727
Debugger [candidate] (66.586 ms) : 0, 66586
Remote Config [baseline] (673.779 µs) : 0, 674
Remote Config [candidate] (650.658 µs) : 0, 651
Telemetry [baseline] (9.153 ms) : 0, 9153
Telemetry [candidate] (9.016 ms) : 0, 9016
Flare Poller [baseline] (3.804 ms) : 0, 3804
Flare Poller [candidate] (3.804 ms) : 0, 3804
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (796.086 ms) : 0, 796086
BytebuddyAgent [candidate] (790.157 ms) : 0, 790157
GlobalTracer [baseline] (256.109 ms) : 0, 256109
GlobalTracer [candidate] (254.894 ms) : 0, 254894
IAST [baseline] (27.304 ms) : 0, 27304
IAST [candidate] (26.76 ms) : 0, 26760
AppSec [baseline] (35.368 ms) : 0, 35368
AppSec [candidate] (34.399 ms) : 0, 34399
Debugger [baseline] (64.714 ms) : 0, 64714
Debugger [candidate] (64.985 ms) : 0, 64985
Remote Config [baseline] (595.25 µs) : 0, 595
Remote Config [candidate] (561.719 µs) : 0, 562
Telemetry [baseline] (8.493 ms) : 0, 8493
Telemetry [candidate] (8.324 ms) : 0, 8324
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.451 ms) : 0, 3451
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section baseline
no_agent (1.219 ms) : 1207, 1231
. : milestone, 1219,
iast (3.219 ms) : 3175, 3264
. : milestone, 3219,
iast_FULL (5.7 ms) : 5643, 5756
. : milestone, 5700,
iast_GLOBAL (3.642 ms) : 3588, 3696
. : milestone, 3642,
profiling (1.948 ms) : 1932, 1965
. : milestone, 1948,
tracing (1.778 ms) : 1763, 1792
. : milestone, 1778,
section candidate
no_agent (1.202 ms) : 1191, 1214
. : milestone, 1202,
iast (3.218 ms) : 3175, 3261
. : milestone, 3218,
iast_FULL (5.824 ms) : 5765, 5882
. : milestone, 5824,
iast_GLOBAL (3.568 ms) : 3513, 3623
. : milestone, 3568,
profiling (1.981 ms) : 1964, 1999
. : milestone, 1981,
tracing (1.833 ms) : 1816, 1851
. : milestone, 1833,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section baseline
no_agent (18.347 ms) : 18157, 18536
. : milestone, 18347,
appsec (18.249 ms) : 18066, 18433
. : milestone, 18249,
code_origins (17.768 ms) : 17591, 17944
. : milestone, 17768,
iast (17.529 ms) : 17353, 17706
. : milestone, 17529,
profiling (18.396 ms) : 18214, 18578
. : milestone, 18396,
tracing (17.751 ms) : 17576, 17927
. : milestone, 17751,
section candidate
no_agent (17.259 ms) : 17083, 17435
. : milestone, 17259,
appsec (18.508 ms) : 18321, 18695
. : milestone, 18508,
code_origins (17.703 ms) : 17527, 17879
. : milestone, 17703,
iast (17.793 ms) : 17616, 17971
. : milestone, 17793,
profiling (21.331 ms) : 21120, 21543
. : milestone, 21331,
tracing (17.789 ms) : 17614, 17965
. : milestone, 17789,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section baseline
no_agent (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
appsec (14.249 s) : 14249000, 14249000
. : milestone, 14249000,
iast (17.86 s) : 17860000, 17860000
. : milestone, 17860000,
iast_GLOBAL (17.054 s) : 17054000, 17054000
. : milestone, 17054000,
profiling (14.219 s) : 14219000, 14219000
. : milestone, 14219000,
tracing (14.05 s) : 14050000, 14050000
. : milestone, 14050000,
section candidate
no_agent (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
appsec (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
iast (17.806 s) : 17806000, 17806000
. : milestone, 17806000,
iast_GLOBAL (17.038 s) : 17038000, 17038000
. : milestone, 17038000,
profiling (14.233 s) : 14233000, 14233000
. : milestone, 14233000,
tracing (14.263 s) : 14263000, 14263000
. : milestone, 14263000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~84852136c2, baseline=1.57.0-SNAPSHOT~39d4c51789
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (4.197 ms) : 3942, 4452
. : milestone, 4197,
iast (2.584 ms) : 2483, 2686
. : milestone, 2584,
iast_GLOBAL (2.634 ms) : 2532, 2736
. : milestone, 2634,
profiling (2.422 ms) : 2335, 2510
. : milestone, 2422,
tracing (2.379 ms) : 2295, 2462
. : milestone, 2379,
section candidate
no_agent (1.494 ms) : 1482, 1505
. : milestone, 1494,
appsec (2.794 ms) : 2710, 2879
. : milestone, 2794,
iast (2.597 ms) : 2494, 2700
. : milestone, 2597,
iast_GLOBAL (2.638 ms) : 2535, 2740
. : milestone, 2638,
profiling (2.419 ms) : 2332, 2507
. : milestone, 2419,
tracing (2.381 ms) : 2297, 2464
. : milestone, 2381,
|
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
1ded8e1 to
fb6cf96
Compare
Base automatically changed from
bdu/enable-css-only-after-agent-7.65.0
to
master
December 9, 2025 16:48
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
cca1811 to
8485213
Compare
amarziali
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: metrics
Metrics
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This simplifies the CSS check by combining the agent version check and the
client_drop_p0ssupport as both are required to support CSS.Motivation
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]