-
Notifications
You must be signed in to change notification settings - Fork 319
Only enable client side stats if the host agent is at least 7.65.0 #10041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081283
Total [baseline] (10.829 s) : 0, 10829207
Agent [candidate] (1.078 s) : 0, 1078314
Total [candidate] (10.863 s) : 0, 10863013
section appsec
Agent [baseline] (1.263 s) : 0, 1263360
Total [baseline] (11.089 s) : 0, 11089388
Agent [candidate] (1.262 s) : 0, 1262426
Total [candidate] (11.075 s) : 0, 11075266
section iast
Agent [baseline] (1.224 s) : 0, 1224354
Total [baseline] (11.197 s) : 0, 11197328
Agent [candidate] (1.226 s) : 0, 1226498
Total [candidate] (11.213 s) : 0, 11212700
section profiling
Agent [baseline] (1.209 s) : 0, 1208729
Total [baseline] (11.076 s) : 0, 11076358
Agent [candidate] (1.203 s) : 0, 1203399
Total [candidate] (11.074 s) : 0, 11074114
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (648.286 ms) : 0, 648286
BytebuddyAgent [candidate] (647.094 ms) : 0, 647094
GlobalTracer [baseline] (281.769 ms) : 0, 281769
GlobalTracer [candidate] (281.033 ms) : 0, 281033
AppSec [baseline] (32.58 ms) : 0, 32580
AppSec [candidate] (32.291 ms) : 0, 32291
Debugger [baseline] (68.325 ms) : 0, 68325
Debugger [candidate] (67.901 ms) : 0, 67901
Remote Config [baseline] (667.409 µs) : 0, 667
Remote Config [candidate] (648.445 µs) : 0, 648
Telemetry [baseline] (9.049 ms) : 0, 9049
Telemetry [candidate] (8.922 ms) : 0, 8922
Flare Poller [baseline] (3.84 ms) : 0, 3840
Flare Poller [candidate] (3.706 ms) : 0, 3706
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (688.065 ms) : 0, 688065
BytebuddyAgent [candidate] (688.036 ms) : 0, 688036
GlobalTracer [baseline] (259.012 ms) : 0, 259012
GlobalTracer [candidate] (258.696 ms) : 0, 258696
AppSec [baseline] (174.528 ms) : 0, 174528
AppSec [candidate] (174.285 ms) : 0, 174285
Debugger [baseline] (66.988 ms) : 0, 66988
Debugger [candidate] (66.71 ms) : 0, 66710
Remote Config [baseline] (683.533 µs) : 0, 684
Remote Config [candidate] (712.049 µs) : 0, 712
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (8.864 ms) : 0, 8864
Flare Poller [baseline] (3.867 ms) : 0, 3867
Flare Poller [candidate] (3.945 ms) : 0, 3945
IAST [baseline] (24.525 ms) : 0, 24525
IAST [candidate] (24.438 ms) : 0, 24438
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (791.266 ms) : 0, 791266
BytebuddyAgent [candidate] (792.557 ms) : 0, 792557
GlobalTracer [baseline] (255.873 ms) : 0, 255873
GlobalTracer [candidate] (256.097 ms) : 0, 256097
AppSec [baseline] (34.622 ms) : 0, 34622
AppSec [candidate] (35.434 ms) : 0, 35434
Debugger [baseline] (66.678 ms) : 0, 66678
Debugger [candidate] (66.123 ms) : 0, 66123
Remote Config [baseline] (592.385 µs) : 0, 592
Remote Config [candidate] (581.35 µs) : 0, 581
Telemetry [baseline] (8.391 ms) : 0, 8391
Telemetry [candidate] (8.484 ms) : 0, 8484
Flare Poller [baseline] (3.446 ms) : 0, 3446
Flare Poller [candidate] (3.484 ms) : 0, 3484
IAST [baseline] (26.745 ms) : 0, 26745
IAST [candidate] (27.08 ms) : 0, 27080
section profiling
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (703.088 ms) : 0, 703088
BytebuddyAgent [candidate] (700.428 ms) : 0, 700428
GlobalTracer [baseline] (222.162 ms) : 0, 222162
GlobalTracer [candidate] (220.722 ms) : 0, 220722
AppSec [baseline] (32.565 ms) : 0, 32565
AppSec [candidate] (32.255 ms) : 0, 32255
Debugger [baseline] (68.79 ms) : 0, 68790
Debugger [candidate] (68.048 ms) : 0, 68048
Remote Config [baseline] (625.591 µs) : 0, 626
Remote Config [candidate] (655.751 µs) : 0, 656
Telemetry [baseline] (9.021 ms) : 0, 9021
Telemetry [candidate] (9.096 ms) : 0, 9096
Flare Poller [baseline] (3.799 ms) : 0, 3799
Flare Poller [candidate] (3.77 ms) : 0, 3770
ProfilingAgent [baseline] (97.814 ms) : 0, 97814
ProfilingAgent [candidate] (97.655 ms) : 0, 97655
Profiling [baseline] (98.382 ms) : 0, 98382
Profiling [candidate] (98.228 ms) : 0, 98228
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078581
Total [baseline] (8.731 s) : 0, 8730895
Agent [candidate] (1.08 s) : 0, 1080381
Total [candidate] (8.753 s) : 0, 8752567
section iast
Agent [baseline] (1.236 s) : 0, 1236461
Total [baseline] (9.489 s) : 0, 9488741
Agent [candidate] (1.221 s) : 0, 1221294
Total [candidate] (9.472 s) : 0, 9472415
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (647.402 ms) : 0, 647402
BytebuddyAgent [candidate] (647.941 ms) : 0, 647941
GlobalTracer [baseline] (281.565 ms) : 0, 281565
GlobalTracer [candidate] (282.273 ms) : 0, 282273
AppSec [baseline] (32.381 ms) : 0, 32381
AppSec [candidate] (32.469 ms) : 0, 32469
Debugger [baseline] (67.111 ms) : 0, 67111
Debugger [candidate] (67.244 ms) : 0, 67244
Remote Config [baseline] (653.026 µs) : 0, 653
Remote Config [candidate] (651.532 µs) : 0, 652
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (9.097 ms) : 0, 9097
Flare Poller [baseline] (3.698 ms) : 0, 3698
Flare Poller [candidate] (3.827 ms) : 0, 3827
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (801.066 ms) : 0, 801066
BytebuddyAgent [candidate] (790.696 ms) : 0, 790696
GlobalTracer [baseline] (257.33 ms) : 0, 257330
GlobalTracer [candidate] (255.291 ms) : 0, 255291
AppSec [baseline] (35.921 ms) : 0, 35921
AppSec [candidate] (35.302 ms) : 0, 35302
Debugger [baseline] (64.999 ms) : 0, 64999
Debugger [candidate] (64.09 ms) : 0, 64090
Remote Config [baseline] (590.236 µs) : 0, 590
Remote Config [candidate] (549.574 µs) : 0, 550
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.341 ms) : 0, 8341
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (3.429 ms) : 0, 3429
IAST [baseline] (27.541 ms) : 0, 27541
IAST [candidate] (26.897 ms) : 0, 26897
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 2 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section baseline
no_agent (1.204 ms) : 1192, 1215
. : milestone, 1204,
iast (3.14 ms) : 3101, 3179
. : milestone, 3140,
iast_FULL (6.111 ms) : 6049, 6173
. : milestone, 6111,
iast_GLOBAL (3.604 ms) : 3551, 3658
. : milestone, 3604,
profiling (2.174 ms) : 2154, 2194
. : milestone, 2174,
tracing (1.82 ms) : 1804, 1836
. : milestone, 1820,
section candidate
no_agent (1.203 ms) : 1192, 1214
. : milestone, 1203,
iast (3.291 ms) : 3243, 3339
. : milestone, 3291,
iast_FULL (5.744 ms) : 5688, 5801
. : milestone, 5744,
iast_GLOBAL (3.729 ms) : 3672, 3785
. : milestone, 3729,
profiling (2.056 ms) : 2037, 2076
. : milestone, 2056,
tracing (1.786 ms) : 1771, 1800
. : milestone, 1786,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section baseline
no_agent (17.588 ms) : 17407, 17769
. : milestone, 17588,
appsec (18.903 ms) : 18709, 19097
. : milestone, 18903,
code_origins (17.606 ms) : 17430, 17782
. : milestone, 17606,
iast (19.012 ms) : 18820, 19205
. : milestone, 19012,
profiling (19.682 ms) : 19482, 19882
. : milestone, 19682,
tracing (17.684 ms) : 17510, 17858
. : milestone, 17684,
section candidate
no_agent (18.354 ms) : 18161, 18547
. : milestone, 18354,
appsec (19.773 ms) : 19570, 19977
. : milestone, 19773,
code_origins (17.782 ms) : 17608, 17956
. : milestone, 17782,
iast (17.78 ms) : 17605, 17956
. : milestone, 17780,
profiling (18.656 ms) : 18474, 18839
. : milestone, 18656,
tracing (17.777 ms) : 17600, 17955
. : milestone, 17777,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section baseline
no_agent (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
appsec (14.678 s) : 14678000, 14678000
. : milestone, 14678000,
iast (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (14.49 s) : 14490000, 14490000
. : milestone, 14490000,
tracing (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
section candidate
no_agent (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
appsec (14.584 s) : 14584000, 14584000
. : milestone, 14584000,
iast (18.267 s) : 18267000, 18267000
. : milestone, 18267000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (15.215 s) : 15215000, 15215000
. : milestone, 15215000,
tracing (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6a7a90800f, baseline=1.57.0-SNAPSHOT~f431e84982
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.672 ms) : 3458, 3886
. : milestone, 3672,
iast (2.213 ms) : 2148, 2277
. : milestone, 2213,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.077 ms) : 2024, 2129
. : milestone, 2077,
tracing (2.042 ms) : 1992, 2093
. : milestone, 2042,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.72 ms) : 3500, 3939
. : milestone, 3720,
iast (2.209 ms) : 2145, 2274
. : milestone, 2209,
iast_GLOBAL (2.247 ms) : 2183, 2312
. : milestone, 2247,
profiling (2.064 ms) : 2012, 2116
. : milestone, 2064,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
|
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
35b0813 to
414bb53
Compare
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Show resolved
Hide resolved
414bb53 to
c08baa1
Compare
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
|
Currently blocked on system tests, because the test agent version is hardcoded to |
…-after-agent-7.65.0
communication/src/main/java/datadog/communication/ddagent/AgentVersion.java
Show resolved
Hide resolved
| */ | ||
| public static boolean isVersionBelow(String version, int maxMajor, int maxMinor, int maxPatch) { | ||
| if (version == null || version.isEmpty()) { | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follwu-up in this conversation: https://github.com/DataDog/dd-trace-java/pull/10041/files#r2593849251
…-after-agent-7.65.0
What Does This Do
Only enable client side stats when the agent is at least 7.65.0.
Motivation
The reason is that container based primary tags are not supported by earlier versions of the host agent and as such can't be reported when CSS is enabled.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]