Conversation
Member
Author
This event display shows a very rough validation of the correction. Note the order of the high-efficiency light traps. The previous implementation incorrectly had the order of the light traps backwards, so that the detector started at the top with the high-efficiency LCMs. Now, we can see that the light detectors follow the true order, with the top light traps being Arclights. |
Member
Author
|
I've noticed an issue. Even before this PR, it looks like single blobs of charge are depositing light on the wrong side of then detector (see image below). I'll merge regardless since this PR fixes an unrelated issue, but this issue should be looked at (maybe it's a plotting bug?). 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorders the optical channel mapping, necessary to do after this PR in larnd-sim.
Previously, larnd-sim was reflecting the y-axis of the LUT, flipping the order of the light detectors and therefore placing the LCMs and Arclights in the incorrect positions. The PR mentioned above removes this reflection, and this PR reorders the optical channel mapping to the correct positions.
Currently trying to validate, but NDLar event displays are very slow to make...