Merged
Conversation
alexbooth92
approved these changes
Nov 21, 2025
Member
alexbooth92
left a comment
alexbooth92
left a comment
There was a problem hiding this comment.
Awesome stuff thanks Alex! Great gifs as usual 😄
jaafar-chakrani
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the op channel mapping issue observed here.
Below is a gif of optical light deposition as a function of charge deposition location before this PR. It looks as if for one TPC in each module, the light is being deposited on the wrong side.
Below is with the corrected optical channel mapping.