Rearrange optical channel mapping for 2x2 after LUT flipping#221
Merged
Rearrange optical channel mapping for 2x2 after LUT flipping#221
Conversation
diaza
requested review from
AWh1t3,
cuddandr,
jaafar-chakrani,
liviocali and
mjkramer
Member
Author
|
The gifs in this comment show that the outputs remain the same, as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rearranges the optical channel mapping after the LUT's have been reflected over the y-axis, which is done in this larnd-sim PR, and should only be merged in conjunction with that PR. Visually, event displays look good to me, but I'd suggest a second set of eyes?