Skip to content

NO JIRA. Changes to support dd-dv-cli. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvanmansum merged 2 commits into from
Feb 2, 2026
Merged

NO JIRA. Changes to support dd-dv-cli. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f0d61
wip
janvanmansum Feb 2, 2026
5b3ab2d
updated dep on dataverse client lib
janvanmansum Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<developerConnection>scm:git:ssh://github.com/DANS-KNAW/${project.artifactId}</developerConnection>
<tag>HEAD</tag>
</scm>

<properties>
<dans-dataverse-client-lib.version>1.6.0</dans-dataverse-client-lib.version>
</properties>

<dependencies>
<dependency>
<groupId>info.picocli</groupId>
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/nl/knaw/dans/lib/util/DataverseClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ public class DataverseClientFactory {
private int awaitIndexingMaxNumberOfRetries = 15;
private int awaitIndexingMillisecondsBetweenRetries = 1000;
private HttpClientConfiguration httpClient = null;
private String databaseUrl;
private String databaseUser;
private String databasePassword;

public DataverseClient build() {
return build(null, null, null);
Expand Down Expand Up @@ -75,7 +78,12 @@ public DataverseClient build(Environment environment, String name, String overri
awaitLockStateMillisecondsBetweenRetries,
awaitIndexingMaxNumberOfRetries,
awaitIndexingMillisecondsBetweenRetries,
unblockKey);
unblockKey,
databaseUrl,
databaseUser,
databasePassword);



Comment on lines +86 to 87
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra blank lines to maintain consistent code formatting.

Suggested change

Copilot uses AI. Check for mistakes.
ObjectMapper objectMapper = environment == null ? new ObjectMapper() : environment.getObjectMapper();
if (httpClient == null) {
Expand Down
Loading