NO JIRA. Changes to support dd-dv-cli. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds database configuration support to the DataverseClientFactory to enable database connectivity features for the dd-dv-cli tool.
Changes:
- Added database connection parameters (URL, username, password) to
DataverseClientFactory - Updated Maven POM to define
dans-dataverse-client-libversion property
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/nl/knaw/dans/lib/util/DataverseClientFactory.java | Added three database configuration fields and passed them to the client builder |
| pom.xml | Introduced version property for dans-dataverse-client-lib dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
87
|
|
||
|
|
There was a problem hiding this comment.
Remove extra blank lines to maintain consistent code formatting.
Suggested change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 47.11% 47.11%
Complexity 101 101
=========================================
Files 29 29
Lines 728 728
Branches 82 82
=========================================
Hits 343 343
Misses 350 350
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO JIRA.
Description of changes
This PR adds database configuration support to the DataverseClientFactory to enable database connectivity features for the dd-dv-cli tool.
Notify
@DANS-KNAW/core-systems