Skip to content

chore: cicd fix and code cleanup#23

Merged
shyam-cb merged 3 commits intomainfrom
fix-cicd-errors-v2
Mar 12, 2026
Merged

chore: cicd fix and code cleanup#23
shyam-cb merged 3 commits intomainfrom
fix-cicd-errors-v2

Conversation

@shyam-cb
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing code quality and maintainability through various cleanup efforts. It includes reordering imports and standardizing formatting in example pipelines, improving the robustness of the telemetry module's event sending mechanism, and refining test assertions for better reliability. These changes contribute to a more consistent and stable codebase without introducing new features.

Highlights

  • Code Formatting and Readability: Standardized multiline function call formatting and reordered imports in example pipelines for improved readability.
  • Telemetry Module Enhancements: Refactored the telemetry module to use threading.Event for more robust single-event sending and contextlib.suppress for cleaner error handling.
  • Linting Configuration Update: Added FBT001 to the lint.ignore list in pyproject.toml to allow boolean positional values in function calls, specifically for cluster options.
  • Test Assertion Improvement: Updated the mock assertion logic in test_retriever.py to check call_args.kwargs for more precise validation of method calls.
  • Docstring and Whitespace Cleanup: Removed extraneous newlines in docstrings and code for better consistency and tidiness across several files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/query/indexing_pipeline.py
    • Reordered imports for better organization.
    • Reformated multiline authenticator and query calls for improved readability.
  • examples/query/rag_pipeline.py
    • Reordered imports for better organization.
    • Reformated multiline authenticator, prompt_messages, and llm component calls for improved readability.
  • examples/search/rag_pipeline.py
    • Reordered imports for better organization.
    • Reformated multiline authenticator, prompt_messages, and llm component calls for improved readability.
  • pyproject.toml
    • Added FBT001 to the lint.ignore list to allow boolean positional arguments in function calls.
  • src/couchbase_haystack/components/retrievers/embedding_retriever.py
    • Removed unnecessary blank lines within docstrings.
  • src/couchbase_haystack/document_stores/document_store.py
    • Removed unnecessary blank lines within docstrings and the _embedding_retrieval method.
  • src/couchbase_haystack/telemetry.py
    • Replaced _telemetry_sent boolean with threading.Event for more reliable single-event sending.
    • Utilized contextlib.suppress for cleaner error handling around package version retrieval and telemetry sending.
    • Updated ScarfEventLogger import to include noqa: PLC0415.
  • tests/search_document_store/test_document_store.py
    • Removed unnecessary blank lines.
  • tests/search_document_store/test_retriever.py
    • Updated mock assertion for _embedding_retrieval to check call_args.kwargs for more precise validation.
  • tests/search_document_store/test_search_filter.py
    • Removed an unnecessary blank line.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes several code cleanup and refactoring changes across multiple files. Key improvements include reordering imports for better organization, enhancing code readability through consistent formatting, and improving the telemetry module's robustness by utilizing contextlib.suppress for error handling and threading.Event for thread-safe signaling. Additionally, the test suite has been improved by adopting a more flexible approach to asserting mock calls. Overall, these changes contribute positively to the codebase's maintainability and clarity.

@shyam-cb shyam-cb merged commit 603ef23 into main Mar 12, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant