Skip to content

chore: cicd fix and code cleanup#22

Closed
shyam-cb wants to merge 12 commits intomainfrom
fix-cicd-errors
Closed

chore: cicd fix and code cleanup#22
shyam-cb wants to merge 12 commits intomainfrom
fix-cicd-errors

Conversation

@shyam-cb
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the codebase's maintainability and consistency. It addresses general code cleanup by standardizing formatting, reordering imports, and ensuring consistent string literal usage. Additionally, it refines test assertions to improve their robustness, contributing to a more stable and readable project.

Highlights

  • Code Formatting and Readability: Improved code readability and consistency across example pipelines and core components through standardized formatting, including import ordering and multi-line argument alignment.
  • String Literal Consistency: Standardized the use of double quotes for string literals across various test files and configuration dictionaries, enhancing code uniformity.
  • Test Robustness: Refactored mock assertion logic in retriever tests to check keyword arguments, making tests more robust to changes in argument order.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/query/indexing_pipeline.py
    • Reordered imports for better organization.
    • Reformatted a multi-line method call for improved readability.
  • examples/query/rag_pipeline.py
    • Reordered imports for better organization.
    • Reformatted multi-line function arguments and string literals for clarity.
  • examples/search/rag_pipeline.py
    • Reordered imports for better organization.
    • Reformatted multi-line function arguments and string literals for clarity.
  • src/couchbase_haystack/components/retrievers/embedding_retriever.py
    • Removed trailing whitespace from docstrings.
  • src/couchbase_haystack/document_stores/document_store.py
    • Removed trailing whitespace from docstrings.
    • Removed a redundant blank line within a method.
  • src/couchbase_haystack/document_stores/search_filters.py
    • Reformatted type hint declarations for property setters to enhance readability.
  • tests/common/common.py
    • Standardized string literal quotes from single to double.
  • tests/gsi_document_store/init.py
    • Standardized string literal quotes in a path insertion.
  • tests/gsi_document_store/test_document_store_integration.py
    • Standardized string literal quotes for model initialization and blob decoding.
  • tests/gsi_document_store/test_sql_filters.py
    • Standardized string literal quotes in a utility function.
  • tests/search_document_store/init.py
    • Standardized string literal quotes in a path insertion.
  • tests/search_document_store/test_document_store.py
    • Standardized string literal quotes for model initialization.
    • Removed blank lines for conciseness.
    • Updated dictionary key quotes to double quotes.
  • tests/search_document_store/test_retriever.py
    • Reordered and removed unused imports.
    • Standardized string literal quotes.
    • Updated mock assertion logic to check keyword arguments for improved robustness.
  • tests/search_document_store/test_search_filter.py
    • Removed a blank line for conciseness.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on improving code readability and organization within the Couchbase Haystack examples and core components. Key changes include refactoring imports in indexing_pipeline.py and rag_pipeline.py to directly import KnownConfigProfiles and QueryOptions from couchbase.options, reformatting multiline arguments and string literals for better readability in various example pipeline files, and cleaning up docstrings by removing unnecessary blank lines in embedding_retriever.py and document_store.py.

@shyam-cb
Copy link
Copy Markdown
Contributor Author

create new PR #23

@shyam-cb shyam-cb closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant