Skip to content

fix: settings modal scrolling and viewport clipping #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxtara merged 5 commits into from
Feb 20, 2026
Merged

fix: settings modal scrolling and viewport clipping #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edbc74d
fix: settings modal scrolling and viewport clipping
maxtara Feb 12, 2026
1c44e3b
Merge branch 'staging' into bug/settings-scroller
maxtara Feb 12, 2026
ee1c33a
Merge branch 'staging' into bug/settings-scroller
maxtara Feb 19, 2026
1e178e2
fix: avoid clipping in settings modal layout
maxtara Feb 19, 2026
e397752
Merge branch 'staging' into bug/settings-scroller
maxtara Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/components/Modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const Modal: React.FC<ModalProps> & {
data-testid={testId}
>
<div
className="bg-copilot-surface border border-copilot-border rounded-lg shadow-xl max-w-[90%]"
className="bg-copilot-surface border border-copilot-border rounded-lg shadow-xl max-w-[90%] max-h-[90vh] flex flex-col my-4"
style={{ width, WebkitAppRegion: 'no-drag' } as React.CSSProperties}
role="dialog"
aria-modal="true"
Expand Down
6 changes: 3 additions & 3 deletions src/renderer/components/SettingsModal/SettingsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,9 +684,9 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({

return (
<Modal isOpen={isOpen} onClose={onClose} title="Settings" width="600px" testId="settings-modal">
<div className="flex min-h-[400px]">
<div className="flex min-h-[400px] flex-1 min-h-0">
{/* Sidebar */}
<div className="w-40 border-r border-copilot-border p-2 shrink-0">
<div className="w-40 border-r border-copilot-border p-2 shrink-0 overflow-y-auto">
{sections.map((section) => (
<button
key={section.id}
Expand All @@ -704,7 +704,7 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
</div>

{/* Content */}
<div className="flex-1 p-4">{renderContent()}</div>
<div className="flex-1 p-4 overflow-y-auto min-h-0">{renderContent()}</div>
</div>
</Modal>
);
Expand Down