fix: Removing a favorite overwrites live message state with stale snapshot#2837
Open
Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Open
fix: Removing a favorite overwrites live message state with stale snapshot#2837Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Conversation
Allaoua9
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes this issue : #2836
update only metadata on the current item from state instead of replacing it wholesale.
Summary by cubic
Fixes a bug where toggling a favorite could overwrite a live message with a stale snapshot (Fixes #2836). We now update only the
favoriteflag inmetadatawithinuseChatInteract, preserving all other message fields.Written for commit 7fdd751. Summary will update on new commits.