Skip to content

fix(search): Fix a11y issue with nested interactive controls #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 2 commits into from
Dec 12, 2025
Merged

fix(search): Fix a11y issue with nested interactive controls #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd1402
fix(search): Fix a11y issue with nested interactive controls
futa-ikeda Dec 3, 2025
9ffdb1e
fix(search): Match CSS to what was there prior
futa-ikeda Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 97 additions & 97 deletions src/app/shared/components/resource-card/resource-card.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,118 +1,118 @@
<div class="resource p-4">
<p-accordion (onOpen)="onOpen()">
<p-accordion-panel value="0">
<p-accordion-panel value="0" class="gap-2">
<p-accordion-header class="flex flex-row align-items-start gap-3 p-0">
<div osfStopPropagation class="flex flex-column align-items-start gap-2">
<p class="type py-1 px-3 font-bold">{{ cardTypeLabel() | translate }}</p>
</div>
</p-accordion-header>

<div class="flex align-items-center gap-2">
<h2>
<a
class="block line-height-4 dark-blue-link word-break-word"
[href]="resource().absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ displayTitle() | fixSpecialChar }}
</a>
</h2>
<div class="flex align-items-center gap-2">
<h2>
<a
class="block line-height-4 dark-blue-link word-break-word"
[href]="resource().absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ displayTitle() | fixSpecialChar }}
</a>
</h2>

@if (isWithdrawn()) {
<p-tag severity="secondary">{{ 'resourceCard.labels.withdrawn' | translate }}</p-tag>
}
@if (isWithdrawn()) {
<p-tag severity="secondary">{{ 'resourceCard.labels.withdrawn' | translate }}</p-tag>
}

@let orcidValues = orcids();
@if (orcidValues.length && orcidValues[0]) {
<a [href]="orcidValues[0]" class="h-1rem" target="_blank" rel="noopener noreferrer">
<img ngSrc="assets/icons/colored/orcid.svg" width="16" height="16" alt="orcid" />
</a>
}
</div>
@let orcidValues = orcids();
@if (orcidValues.length && orcidValues[0]) {
<a [href]="orcidValues[0]" class="h-1rem" target="_blank" rel="noopener noreferrer">
<img ngSrc="assets/icons/colored/orcid.svg" width="16" height="16" alt="orcid" />
</a>
}
</div>

@if (affiliatedEntities().length > 0) {
<div class="line-height-3">
@for (affiliatedEntity of affiliatedEntities().slice(0, limit); track $index) {
<a
class="word-break-word block line-height-3"
[href]="affiliatedEntity.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ affiliatedEntity.name }}{{ $last ? '' : ', ' }}
</a>
}
@if (resource().creators.length > limit) {
<p class="inline">
&nbsp;{{ 'resourceCard.andCountMore' | translate: { count: resource().creators.length - limit } }}
</p>
}
</div>
@if (affiliatedEntities().length > 0) {
<div class="line-height-3">
@for (affiliatedEntity of affiliatedEntities().slice(0, limit); track $index) {
<a
class="word-break-word block line-height-3"
[href]="affiliatedEntity.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ affiliatedEntity.name }}{{ $last ? '' : ', ' }}
</a>
}

@if (resource().isPartOf) {
<div class="flex flex-row gap-1 line-height-3">
<p class="white-space-nowrap">{{ 'resourceCard.labels.from' | translate }}</p>
<a
class="block line-height-4 white-space-normal word-break-word"
[href]="resource().isPartOf!.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ resource().isPartOf!.name }}
</a>
</div>
@if (resource().creators.length > limit) {
<p class="inline">
&nbsp;{{ 'resourceCard.andCountMore' | translate: { count: resource().creators.length - limit } }}
</p>
}
</div>
}

@if (resource().isContainedBy) {
<div class="flex flex-row gap-1 line-height-3">
<p class="white-space-nowrap">{{ 'resourceCard.labels.from' | translate }}</p>
<a
class="block line-height-4 white-space-normal"
[href]="resource().isContainedBy!.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ resource().isContainedBy!.name }}
</a>
</div>
}
@if (resource().isPartOf) {
<div class="flex flex-row gap-1 line-height-3">
<p class="white-space-nowrap">{{ 'resourceCard.labels.from' | translate }}</p>
<a
class="block line-height-4 white-space-normal word-break-word"
[href]="resource().isPartOf!.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ resource().isPartOf!.name }}
</a>
</div>
}

@if (dateFields().length > 0) {
<div class="flex flex-column md:flex-row line-height-3">
@for (dateField of dateFields(); track $index) {
<p>{{ dateField.label | translate }}: {{ dateField.date | date: 'MMMM d, y' : 'UTC' }}</p>
@if (resource().isContainedBy) {
<div class="flex flex-row gap-1 line-height-3">
<p class="white-space-nowrap">{{ 'resourceCard.labels.from' | translate }}</p>
<a
class="block line-height-4 white-space-normal"
[href]="resource().isContainedBy!.absoluteUrl"
target="_blank"
rel="noopener noreferrer"
>
{{ resource().isContainedBy!.name }}
</a>
</div>
}

@if (!$last && !isSmall()) {
<p class="mx-1">
{{ '|' }}
</p>
}
}
</div>
}
@if (dateFields().length > 0) {
<div class="flex flex-column md:flex-row line-height-3">
@for (dateField of dateFields(); track $index) {
<p>{{ dateField.label | translate }}: {{ dateField.date | date: 'MMMM d, y' : 'UTC' }}</p>

@if (resource().context) {
<div class="flex flex-row gap-1 line-height-3 flex-wrap">
<p [innerHTML]="`${'resourceCard.labels.context' | translate}: ${resource().context}`"></p>
</div>
@if (!$last && !isSmall()) {
<p class="mx-1">
{{ '|' }}
</p>
}
}
</div>
}

@if (
resource().resourceType === ResourceType.Registration ||
resource().resourceType === ResourceType.RegistrationComponent
) {
<osf-data-resources
class="mt-1"
[absoluteUrl]="resource().absoluteUrl"
[hasData]="!!resource().hasDataResource"
[hasAnalyticCode]="resource().hasAnalyticCodeResource"
[hasMaterials]="resource().hasMaterialsResource"
[hasPapers]="resource().hasPapersResource"
[hasSupplements]="resource().hasSupplementalResource"
/>
}
@if (resource().context) {
<div class="flex flex-row gap-1 line-height-3 flex-wrap">
<p [innerHTML]="`${'resourceCard.labels.context' | translate}: ${resource().context}`"></p>
</div>
</p-accordion-header>
}

@if (
resource().resourceType === ResourceType.Registration ||
resource().resourceType === ResourceType.RegistrationComponent
) {
<osf-data-resources
class="mt-1"
[absoluteUrl]="resource().absoluteUrl"
[hasData]="!!resource().hasDataResource"
[hasAnalyticCode]="resource().hasAnalyticCodeResource"
[hasMaterials]="resource().hasMaterialsResource"
[hasPapers]="resource().hasPapersResource"
[hasSupplements]="resource().hasSupplementalResource"
/>
}
<p-accordion-content>
<div class="flex flex-column pt-1">
<hr class="w-full break-line my-2" />
Expand Down
4 changes: 4 additions & 0 deletions src/app/shared/components/resource-card/resource-card.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
font-weight: 400;
}

a {
font-weight: 700;
}

.break-line {
border: none;
border-top: 1px solid var(--grey-2);
Expand Down