fix(search): Fix a11y issue with nested interactive controls #804
+101
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
|
@futa-ikeda Some styles changed after your update. It’s better to keep them the same as before. Before changes: After changes: |
Collaborator
|
@futa-ikeda Fix conflicts. |
futa-ikeda
force-pushed
the
fix/eng-9072
branch
from
59026e1 to
cbd1402
Compare
nsemets
approved these changes
Dec 12, 2025
futa-ikeda
merged commit a97c915
into
CenterForOpenScience:feature/pbs-25-24
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
<p-accordion-header>closing tag to just enclose the top section of the search result cardScreenshot(s)
Side Effects
QA Notes