-
Notifications
You must be signed in to change notification settings - Fork 0
Implements flexure compensation #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
astronomerdave
wants to merge
20
commits into
main
Choose a base branch
from
flexure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… datatypes addresses issue 321
Adds SessionPool class, which on construction creates a pool of connected database sessions using a queue. Modifies the existing Database class to make use of SessionPool, retrieving/returning connections from/to the pool. Clients don't know anything about a pool. Adds helper functions to Database to insert, update and read database records. Updates database clients (sequencerd, acamd, thermald) to make use of this. This addresses Issue #314
resolve merge conflict
adds compensate functionality cleans up signal handler
and adds some test functions. ready to test.
instead of current position. This should complete flexure.
Contributor
Author
|
resolves issue #304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates Matt's algorithms to compensate for flexure. The basic procedure is:
Matt's position coefficients (3 per channel per axis) and flexure polynomials (20 per channel per axis) are read from the .cfg file and stored in a map indexed by the pair { channel, axis }
Matt's shift calculation function uses sine or cosine for different axes, and that is encapsulated in another map indexed by channel.
The user interface is
Flexure::Interface::compensateinvoked by sendingcompcommand to the server and for each specified axis will validate tcs telemetry, calculate the compensation, then send those offsets to the motors.flexuredsubscribes totcsdto automatically keep up to date on TCS telemetry but if telemetry is older than 10 seconds then it publishes a request for tcsd to republish telemetry.This branch was started a long time ago, so it will need some merging to catch up.This PR will remain in draft mode until any merging and testing is done.