Merged
Conversation
guillaumeeb
reviewed
Nov 14, 2025
Member
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
This looks really good, but just two comments on pinned dependencies and pycache folder.
guillaumeeb
reviewed
Nov 19, 2025
| 'gdal>=3.5.0,<3.10', | ||
| 'tqdm>=4.66' | ||
| 'tqdm>=4.66', | ||
| 'numpy<2' |
Member
There was a problem hiding this comment.
Hm, this could be a major problem at some point...
Collaborator
Author
There was a problem hiding this comment.
I agree. With numpy >= 2, there are differences in statistical calculations, especially the mean. I haven't checked further. I think it would be better to deal with this in another issue, as it may require changes in the code.
Member
There was a problem hiding this comment.
I concur totally, let's merge this one and open another issue for the future.
Member
|
Seems there is a problem in CI after the merge, could you take a look @celine-raille ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #28 .
Loose some dependencies
Upgrade CI and CD
Update Docker image