Fixes to particle coupling on arbitrary grid#540
Merged
llaniewski merged 7 commits intoCFD-GO:developfrom Mar 12, 2026
Merged
Conversation
On arbitrary lattice getCoord returns in real units, whereas in cartesian lattice it is lattice units. Then X, Y,Z macros on node return in real units which is not expected, and maybe it impossible to find particles (because particles are using lattice units). Need to also tweak vtk export
llaniewski
requested changes
Mar 10, 2026
Member
llaniewski
left a comment
There was a problem hiding this comment.
@shkodm, this is good. Just fix the override tags the clang compiler is failing on https://github.com/CFD-GO/TCLB/actions/runs/22888346758/job/66406017687?pr=540#step:5:246
Were not triggered previously because destructor was virtual. Now more consistent with CartLattice
Member
Author
|
|
Member
Author
|
@llaniewski this should be good now |
llaniewski
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
px,py,pzoffsetscxnfile). So if units were sets, arbitrary grid would have trouble finding particles correctly. And the results from RInside were completely wrong - multiplied by units twice. I changed that to store coordinates in LBM units, and convert using the grid spacing when necessary.Tested by: