Implemented sampler on Arbitrary grid and fixes for cartesian one#541
Merged
llaniewski merged 5 commits intoCFD-GO:developfrom Mar 12, 2026
Merged
Implemented sampler on Arbitrary grid and fixes for cartesian one#541llaniewski merged 5 commits intoCFD-GO:developfrom
llaniewski merged 5 commits intoCFD-GO:developfrom
Conversation
llaniewski
requested changes
Mar 10, 2026
|
|
||
| CudaDeviceFunction void Execute() const { | ||
| using LA = ArbLatticeAccess; | ||
| using N = Node< LA, Primal, NoGlobals, Get >; |
The problem was that the "intersection" of regions does not convert to the local coordinates, so the "over" coordinates were incorrecte (still global)
Were not triggered previously because destructor was virtual. Now more consistent with CartLattice
Member
Author
|
Had the same issue with override virtual functions as in #540 (comment). Should be fixed now |
llaniewski
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Arbitrary grid:
On Cartesian grid
intersectdoes the intersection of bounding boxes, not the conversion into coordinate frames). Fix by offsetting the point into the local coordinate systemTested by:
Bounding Box changes are the same as in #540