Skip to content

dpdk: move RSS configuration into port configuration #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiskaPavel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dpdk: move RSS configuration into port configuration #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/plugins/input/dpdk/src/dpdkDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ DpdkDevice::DpdkDevice(
configurePort();
initMemPools(memPoolSize);
setupRxQueues(memPoolSize);
configureRSS();
enablePort();
}

Expand Down Expand Up @@ -154,7 +153,9 @@ rte_eth_conf DpdkDevice::createPortConfig()

if (m_supportedRSS) {
portConfig.rxmode.mq_mode = RTE_ETH_MQ_RX_RSS;
portConfig.rx_adv_conf.rss_conf = createRSSConfig();
} else {
std::cerr << "Skipped RSS hash setting for port " << m_portID << "." << std::endl;
portConfig.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
}

Expand Down Expand Up @@ -220,12 +221,9 @@ void DpdkDevice::setupRxQueues(uint16_t memPoolSize)
<< " set up. Size of each queue: " << rxQueueSize << std::endl;
}

void DpdkDevice::configureRSS()
rte_eth_rss_conf DpdkDevice::createRSSConfig()
{
if (!m_supportedRSS) {
std::cerr << "Skipped RSS hash setting for port " << m_portID << "." << std::endl;
return;
}
struct rte_eth_rss_conf rssConfig = {};

rte_eth_dev_info rteDevInfo;
if (rte_eth_dev_info_get(m_portID, &rteDevInfo)) {
Expand All @@ -249,17 +247,10 @@ void DpdkDevice::configureRSS()
<< std::endl;
}

struct rte_eth_rss_conf rssConfig = {};
rssConfig.rss_key = m_hashKey.data();
rssConfig.rss_key_len = rssHashKeySize;
rssConfig.rss_hf = rssOffloads;

int ret = rte_eth_dev_rss_hash_update(m_portID, &rssConfig);
if (ret < 0) {
std::cerr << "Setting RSS {" << rssOffloads << "} for port " << m_portID
<< " failed. Errno:" << ret << std::endl;
throw PluginError("DpdkDevice::configureRSS() has failed.");
}
return rssConfig;
}

void DpdkDevice::enablePort()
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/input/dpdk/src/dpdkDevice.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class DpdkDevice {
rte_eth_conf createPortConfig();
void initMemPools(uint16_t memPoolSize);
void setupRxQueues(uint16_t memPoolSize);
void configureRSS();
rte_eth_rss_conf createRSSConfig();
void enablePort();
void createRteMempool(uint16_t mempoolSize);
void setRxTimestampDynflag();
Expand Down