Fix font file embedding mismatch between FontFileFinder and EpubMaker#7655
Closed
Copilot wants to merge 3 commits intoBL-15558FixFontEmbeddingfrom
Closed
Fix font file embedding mismatch between FontFileFinder and EpubMaker#7655Copilot wants to merge 3 commits intoBL-15558FixFontEmbeddingfrom
Copilot wants to merge 3 commits intoBL-15558FixFontEmbeddingfrom
Conversation
Also, give the user a chance to read notes like ones about font embedding. Review: JohnThomson - progressKind switch cleanup -> clearer fall-through Review: andrew-polk - AddFontFace step number -> rename to Step 3 3rd
…uests This aligns FontFileFinder.GetFileForFont with EpubMaker.AddFontFace's cascade (BoldItalic > Italic > Bold > Normal), ensuring the font files copied into BloomPUB match the files referenced in fonts.css. Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback from review on PR #7644
Fix font file embedding mismatch between FontFileFinder and EpubMaker
Feb 4, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
hatton
force-pushed
the
BL-15558FixFontEmbedding
branch
from
cdaecb5 to
9e858ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BoldItalic font variant is missing,
EpubMaker.AddFontFacegenerates CSS referencing the Italic fallback, butFontFileFinder.GetFileForFontreturns the Bold fallback, causing BloomPUB to embed the wrong font file.Changes
FontFileFinder.GetFileForFontfallback priority withEpubMaker.AddFontFace: BoldItalic > Italic > Bold > NormalImpact
For a BoldItalic request with only Italic and Bold available:
This ensures CSS font references match embedded files, preventing missing font errors in BloomPUBs and EPUBs.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is