Skip to content

Cleanup from iot devices panel#418

Merged
ducky64 merged 9 commits intomasterfrom
iot-clean
Jul 14, 2025
Merged

Cleanup from iot devices panel#418
ducky64 merged 9 commits intomasterfrom
iot-clean

Conversation

@ducky64
Copy link
Copy Markdown
Collaborator

@ducky64 ducky64 commented Jul 13, 2025

Miscellaneous cleanup

  • Fix AH1806 pinning
  • Remove ADC2 from ESP32C3 (can't be used with WiFi), repin examples to use other pins
  • Change inheritance ordering of parts tables parts to base class (eg TableInductor) last, logic being that is the most general and the parts table generic logic (eg, JlcParts) is more specific and should handle delegating of things like filtering.
    • This requires a change in the capacitor structure for parallel capacitor generation, which must be handled at the top level since it's not generating a part and needs to skip footprint generation which is sandwiched between the top-level and capacitor table. Least worst solution for something that's fundamentally abstraction breaking.
  • Deprecate SeriesPowerPptcFuse, use SeriesPowerFuse + refinement
  • Deprecate LedDriverSwitchingConverter, setting the ripple as a spec doesn't really make sense, it should be internal.
  • Can't refactor Al8861 to use the new buck converter architecture since its design guide is weird.
  • Fix library viewer tree via categorizations and non_library annotations

Resolves #415

@ducky64 ducky64 requested a review from Copilot July 13, 2025 21:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs miscellaneous cleanup related to IoT device panels, including pin reassignments, fuse API updates, and class inheritance reordering for part definitions.

  • Replace the deprecated SeriesPowerPptcFuse with the generic SeriesPowerFuse and deprecate the old PPTC-specific class.
  • Remove ADC2 from the ESP32-C3 pin model and repin sense signals (vin_sense, vobd_sense) in all examples.
  • Reorder mixin and base-class inheritance across many part classes, add internal/non-library annotations, and update parallel capacitor handling.

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
examples/test_pcbbot.py Swapped SeriesPowerPptcFuse for SeriesPowerFuse
examples/test_iot_blinds.py & related SVG/NET files Updated vin_sense and vobd_sense pin numbers
examples/high_switch, test_datalogger, test_can_adapter Updated fuse mappings and replaced PPTC fuse in refinements
edg/parts/Microcontroller_Esp32c3.py Removed ADC2_CH0 mapping from MTDI
edg/parts/MagneticSwitch_Ah1806.py Corrected KiCad footprint pin order for AH1806
edg/parts & edg/jlcparts (many files) Reordered class inheritance for part selectors and footprinters
edg/electronics_model/CircuitBlock.py Marked WrapperFootprintBlock as non-library
edg/abstract_parts/* Added RfFilter category, deprecated old fuse/LED-driver interfaces
Comments suppressed due to low confidence (1)

edg/parts/PassiveConnector_Header.py:124

  • The base class JstPhSmVertical is not imported or defined in this module, which will cause a NameError. Ensure that JstPhSmVertical is correctly imported or adjust the inheritance to the intended class.
class JstPhSmVerticalJlc(JlcPart, JstPhSmVertical):

(['rgb', 'package'], ThtRgbLed),
(['npx_key'], Sk6812Mini_E),

(['fuse', 'fuse'], PptcFuse),
Copy link

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class_refinements entry still references PptcFuse but the example has been updated to use SeriesPowerFuse. Update this to reference Fuse (or the appropriate fuse type) to match the new API.

Suggested change
(['fuse', 'fuse'], PptcFuse),
(['fuse', 'fuse'], SeriesPowerFuse),

Copilot uses AI. Check for mistakes.
@ducky64 ducky64 merged commit 673d432 into master Jul 14, 2025
12 checks passed
@ducky64 ducky64 deleted the iot-clean branch July 14, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change parts table inheritance order

2 participants