Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs miscellaneous cleanup related to IoT device panels, including pin reassignments, fuse API updates, and class inheritance reordering for part definitions.
- Replace the deprecated
SeriesPowerPptcFusewith the genericSeriesPowerFuseand deprecate the old PPTC-specific class. - Remove ADC2 from the ESP32-C3 pin model and repin sense signals (
vin_sense,vobd_sense) in all examples. - Reorder mixin and base-class inheritance across many part classes, add internal/non-library annotations, and update parallel capacitor handling.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/test_pcbbot.py | Swapped SeriesPowerPptcFuse for SeriesPowerFuse |
| examples/test_iot_blinds.py & related SVG/NET files | Updated vin_sense and vobd_sense pin numbers |
| examples/high_switch, test_datalogger, test_can_adapter | Updated fuse mappings and replaced PPTC fuse in refinements |
| edg/parts/Microcontroller_Esp32c3.py | Removed ADC2_CH0 mapping from MTDI |
| edg/parts/MagneticSwitch_Ah1806.py | Corrected KiCad footprint pin order for AH1806 |
| edg/parts & edg/jlcparts (many files) | Reordered class inheritance for part selectors and footprinters |
| edg/electronics_model/CircuitBlock.py | Marked WrapperFootprintBlock as non-library |
| edg/abstract_parts/* | Added RfFilter category, deprecated old fuse/LED-driver interfaces |
Comments suppressed due to low confidence (1)
edg/parts/PassiveConnector_Header.py:124
- The base class
JstPhSmVerticalis not imported or defined in this module, which will cause aNameError. Ensure thatJstPhSmVerticalis correctly imported or adjust the inheritance to the intended class.
class JstPhSmVerticalJlc(JlcPart, JstPhSmVertical):
| (['rgb', 'package'], ThtRgbLed), | ||
| (['npx_key'], Sk6812Mini_E), | ||
|
|
||
| (['fuse', 'fuse'], PptcFuse), |
There was a problem hiding this comment.
The class_refinements entry still references PptcFuse but the example has been updated to use SeriesPowerFuse. Update this to reference Fuse (or the appropriate fuse type) to match the new API.
Suggested change
| (['fuse', 'fuse'], PptcFuse), | |
| (['fuse', 'fuse'], SeriesPowerFuse), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous cleanup
Resolves #415