feat: Mass spectrometry mapper#1122
Merged
slopez-b merged 10 commits intoBenchling-Open-Source:mainfrom Dec 19, 2025
Merged
Conversation
tests/allotrope/schema_parser/mass_spectrometry_mapper_dummy_data_test.py
Outdated
Show resolved
Hide resolved
joshua-benchling
previously approved these changes
Nov 21, 2025
nathan-stender
requested changes
Dec 3, 2025
Collaborator
nathan-stender
left a comment
nathan-stender
left a comment
There was a problem hiding this comment.
Code LGTM - but tests should be in the same directory path as the file they are testing, in this case, you could probably leave out rec/_2025/_06/... and just have the test at the base of tests/allotropy/schema_mappers/adm/mass_spectrometry.
Contributor
Author
|
@nathan-stender Sorry I hadn't seen that comment, I pushed a commit moving the test file to the correct path, let me know what you think |
Collaborator
joshua-benchling
left a comment
joshua-benchling
left a comment
There was a problem hiding this comment.
Seems like the test file was removed instead.
Contributor
Author
|
@joshua-benchling opss my bad, I just added it again |
joshua-benchling
previously approved these changes
Dec 10, 2025
nathan-stender
approved these changes
Dec 15, 2025
nathan-stender
added a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic mapper for mass spectrometry and a test