-
Notifications
You must be signed in to change notification settings - Fork 2
Use native node for running the bot #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JstnMcBrd
wants to merge
12
commits into
main
Choose a base branch
from
mcb/native-node-ts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
52a4468
Fix node requirement
JstnMcBrd c1b69c8
Rewrite all internal imports from .js to .ts
JstnMcBrd b647c25
Enforce erasable syntax
JstnMcBrd e74a598
Run main.ts directly
JstnMcBrd 53f39b2
Replace build step with type-checking only
JstnMcBrd 2f4143f
Remove references to dist
JstnMcBrd d021ac5
Update Dockerfile
JstnMcBrd 63669f5
Address new type errors
JstnMcBrd 4285336
Delete nodemon.json
JstnMcBrd 2b8dc31
Update CHANGELOG.md
JstnMcBrd 1b6fee8
Revert "Build(deps-dev): Bump keep-a-changelog from 3.0.2 to 3.0.3 (#…
JstnMcBrd 8b953e4
Remove source-map-support
JstnMcBrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,6 @@ logs | |
| # Generated files | ||
| node_modules | ||
| db | ||
| dist | ||
| coverage | ||
| src/constants/version.ts | ||
| tmp | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,31 @@ | ||
| FROM node:24-slim as builder | ||
|
|
||
| RUN apt-get update -y | ||
| RUN apt-get install -y openssl | ||
| FROM node:24-slim AS builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN npm ci | ||
| RUN npm run export-version | ||
| RUN npm run build --omit=dev | ||
|
|
||
| FROM node:24-slim as runner | ||
| FROM node:24-slim AS runner | ||
|
|
||
| ENV NODE_ENV=production | ||
|
|
||
| RUN apt-get update -y | ||
| RUN apt-get install -y openssl | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY --from=builder /app/dist/ ./dist/ | ||
| COPY --from=builder /app/res/ ./res/ | ||
| COPY --exclude=**/*.test.* --exclude=**/__mocks__/** src ./src/ | ||
| COPY --from=builder /app/src/constants/version.ts ./src/constants/ | ||
| COPY res ./res/ | ||
| COPY package*.json ./ | ||
| COPY prisma prisma/ | ||
| COPY scripts/launch_in_docker.sh . | ||
| COPY scripts/launch_in_docker.sh ./scripts/ | ||
|
|
||
| RUN npm ci --omit=dev | ||
|
|
||
| # Path internal to container; use `volumes` config to specify real system path of `/db/` | ||
| ENV DATABASE_URL="file:/db/db.sqlite" | ||
|
|
||
| # Using bash here to get consistent behavior and configurations | ||
| CMD ["bash", "/app/launch_in_docker.sh"] | ||
| CMD ["bash", "/app/scripts/launch_in_docker.sh"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about removing this line. Shouldn't we update the package lists before trying to install packages?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only when you want the most recent package versions, which is unnecessary for our use case (simply installing any version of openssl). Relying on auto-updates from
node:24-slimis sufficient.Each line of a Dockerfile is an additional layer, so I figure it's better to cut it.