Use native node for running the bot#562
Conversation
|
The branch protection rules need to be updated to expect |
|
|
||
| ENV NODE_ENV=production | ||
|
|
||
| RUN apt-get update -y |
There was a problem hiding this comment.
Not sure about removing this line. Shouldn't we update the package lists before trying to install packages?
There was a problem hiding this comment.
Only when you want the most recent package versions, which is unnecessary for our use case (simply installing any version of openssl). Relying on auto-updates from node:24-slim is sufficient.
Each line of a Dockerfile is an additional layer, so I figure it's better to cut it.
|
I'm not sure on removing the "build" stage yet. I'm hoping to eventually set up something like Rollup so we can tree-shake and avoid including node_modules in the final bundle, and setting that up would require reinstating that build step and possibly undoing this entire PR later 😓 |
)" This reverts commit 296a91e.
8121631 to
1b6fee8
Compare
Hmm. I'm not sure what value minifying, tree-shaking, or bundling would have for a project like this. It's not a web-loaded script, web app, or a library/package where download size+speed matters, and performance gains would likely be marginal. In comparison, the simplicity + reduced cognitive load + improved devx of simply running the script directly seems very valuable. What do you think? |
Follow up to #541
Modernizes and simplifies our setup
Changes
.jsto.tserasableSyntaxOnlysrc/main.tsdistDockerfileto reflect build changes