Conversation
Contributor
Author
|
I see the Circle CI build is failing here. Appreciate any help on this. Thanks! |
jsnajdr
approved these changes
Mar 14, 2024
Member
jsnajdr
left a comment
There was a problem hiding this comment.
Looks good. It's also the kind of PR that didn't really need review.
Contributor
Author
|
Thanks, @jsnajdr! |
9618004 to
06e8d7f
Compare
Member
|
The CircleCI check is green now 🙂 It was failing because SSH keys used by CircleCI to checkout code from GitHub were no longer working for some reason. I was able to fix it simply by removing the project from CircleCI and then adding it again. One other thing I tried is to upgrade the testing CircleCI Docker image from the legacy |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
To test the changes done to the newly added environment for Automattic for Agencies on Calypso live links, we need to update the environments here to support that environment.
Changes
This PR
a8c-for-agenciesto theenvsin thesrc/config.tsfile.caseto the switch statement fora8c-for-agenciesthat returnsEnvresolving NODE_ENV and CALYPSO_ENV toa8c-for-agencies-horizon.Testing
dserve(it may take a while to update thewp-calypsorepo).