Introduce a Calypso environment for hosts.automattic.com#92874
Introduce a Calypso environment for hosts.automattic.com#92874
Conversation
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~80 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~346 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
tyxla
left a comment
There was a problem hiding this comment.
This looks good @rcoll, nice work 👍
If you wish to use calypso.live branches, you might need some dserve changes, similar to Automattic/dserve#224.
cc @yashwin since you also worked on some of those initial setup tasks and might have additional tips.
| "a8c-for-hosts": true | ||
| }, | ||
| "site_filter": [], | ||
| "theme": "a8c-for-agencies", |
There was a problem hiding this comment.
Are we going to use the same theme as a4a?
yashwin
left a comment
There was a problem hiding this comment.
Overall, it looks good.
I just left a few comments.
| } | ||
|
|
||
| if ( calypsoEnv === 'a8c-for-hosts-stage' ) { | ||
| context.badge = 'a8c-for-agencies-staging'; |
There was a problem hiding this comment.
Do we want to use the same badge as A4A?
| group: 'a8c-for-agencies', | ||
| }, | ||
| { | ||
| name: 'a8c-for-hosts', |
There was a problem hiding this comment.
It is better to set the section to false here:
wp-calypso/config/_shared.json
Line 161 in 1d7aa96
This could cause some issues because all the sections in WP.com are enabled by default.
pedEI5-1pD-p2
Proposed Changes
a8c-for-hosts-development,a8c-for-hosts-stage,a8c-for-hosts-production.hosts.automattic.comandhosts.localhostas allowed origins.Testing Instructions
start-a8c-for-hosts.http://hosts.localhost:3000and verify you seeHello, world.Pre-merge Checklist