Skip to content

release-20260212 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iDome89 merged 5 commits into from
Feb 12, 2026
Merged

release-20260212 #218

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40fb759
fix(FormContent): update supplier creation logic to directly use supp…
Kariamos Feb 11, 2026
0306bbd
Merge pull request #216 from AppQuality/fix-bug-supplier-creation
d-beezee Feb 11, 2026
ac26c93
fix(OtherCosts): update supplier options to use supplier ID instead o…
Kariamos Feb 11, 2026
024b2ae
fix(OtherCosts): update cost type options to use item ID instead of i…
iDome89 Feb 12, 2026
b80231e
Merge pull request #217 from AppQuality/use-correct-index-supplier
Kariamos Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/pages/campaigns/quote/sections/OtherCosts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ const useCostTypes = ({ campaignId }: { campaignId: string }) => {

const options = useMemo(() => {
if (!data?.items) return [];
return data.items.map((item, index) => ({
value: String(index + 1),
label: item.name || `Type ${index + 1}`,
return data.items.map((item) => ({
value: String(item.id),
label: item.name,
}));
}, [data]);

Expand All @@ -68,8 +68,8 @@ const useSuppliers = ({ campaignId }: { campaignId: string }) => {

const options = useMemo(() => {
if (!data?.items) return [];
return data.items.map((item, index) => ({
value: String(index + 1),
return data.items.map((item) => ({
value: String(item.id),
label: item.name,
}));
}, [data]);
Expand Down Expand Up @@ -249,19 +249,18 @@ const FormContent = ({ campaignId }: { campaignId: string }) => {
}}
onCreateOption={async (inputValue: string) => {
try {
const response = await createSupplier({
const supplierId = await createSupplier({
campaign: campaignId,
body: { name: inputValue },
})
.unwrap()
.then((res) => res.supplier_id);

await refetchSuppliers();
arrayHelpers.replace(index, {
...item,
supplier: supplierId,
});
if ("data" in response) {
await refetchSuppliers();
const newSupplierId =
(suppliers?.length || 0) + 1;
arrayHelpers.replace(index, {
...item,
supplier: newSupplierId,
});
}
} catch (e) {
console.error("Failed to create supplier:", e);
}
Expand Down
Loading