Conversation
fix(FormContent): update supplier creation logic to directly use supp…
fix(OtherCosts): update supplier options to use supplier ID instead o…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how supplier and cost type options are generated and selected in the
OtherCostssection. Instead of relying on array indices, the code now uses unique IDs from the backend for both suppliers and cost types. This improves data consistency and prevents potential issues if the order of items changes. Additionally, the supplier creation flow is updated to use the new ID returned from the backend.Key improvements:
Option Value Handling
useCostTypesanduseSuppliershooks to use each item's uniqueidas the option value instead of the array index, ensuring more reliable identification and selection of options. [1] [2]Supplier Creation Flow
FormContentto use the actualsupplier_idreturned from the backend API when adding a new supplier, rather than calculating a new ID based on the current array length.