fix(file-browser): sync open folder tree after delete#2031
Merged
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom Apr 14, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR fixes a stale-state bug where deleting a file or folder removed the DOM element directly without calling Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant execOperation
participant removeEntryFromOpenFolder
participant sidebarApps
participant FileTree
User->>execOperation: right-click → Delete
execOperation->>execOperation: fsOperation(url).delete()
execOperation->>removeEntryFromOpenFolder: removeEntryFromOpenFolder(url)
removeEntryFromOpenFolder->>sidebarApps: "getAll([data-url="CSS.escape(url)"])"
sidebarApps-->>removeEntryFromOpenFolder: $els[]
loop for each $el
removeEntryFromOpenFolder->>removeEntryFromOpenFolder: resolve ownerTree via _fileTree
alt ownerTree found
removeEntryFromOpenFolder->>FileTree: ownerTree.removeEntry(url)
FileTree->>FileTree: splice entries[]
FileTree->>FileTree: remove DOM element
else no ownerTree
removeEntryFromOpenFolder->>removeEntryFromOpenFolder: direct DOM remove
end
end
execOperation->>execOperation: editorManager.onupdate / emit
Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2028