Closed
Conversation
This commit attempts to fix the stale files state issue occuring from Internal State of fileTree. regression: to be found, how it occurred recently.
Contributor
Greptile SummaryThis PR correctly addresses the prior review feedback: Confidence Score: 2/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[deleteFile called] --> B{helpers.isFile?}
B -- yes --> C[capture $parent = $target.parentElement]
C --> D[$target.remove]
D --> E[update editorManager]
B -- no --> F[delete dir recursively]
F --> G[capture $parent = $target.parentElement?.parentElement]
G --> H[$target.parentElement.remove]
H --> I[update editorManager]
E --> J[toast + FileList.remove]
I --> J
J --> K[await removeEntryFromFileTree url,$parent]
K --> L{$parent._fileTree exists?}
L -- yes --> M[fileTree.removeEntry url]
L -- no --> N[no-op, legacy tile already removed]
M --> O[Done]
N --> O
style K fill:#f96,stroke:#c33
note1[Lines 1070-1082: orphaned block\nstray closing brace causes SyntaxError]
K -.->|broken by parse error| note1
Reviews (2): Last reviewed commit: "Update openFolder.js" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Member
Author
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
Member
Author
|
This has been superseded by #2031 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix the stale files state issue occuring from Internal State of fileTree.
regression: to be found, how it occurred recently.