build: add images Makefile, update gitignore#243
Open
amd-aliem wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the developer workflow for building SEV-SNP host/guest mkosi images by adding a dedicated images/ Makefile, documenting image naming/build usage, and ignoring mkosi-generated build artifacts in Git.
Changes:
- Add
images/Makefilewith targets to list, build, clean, and inspect mkosi images by directory name. - Add
images/README.mddocumenting naming conventions, Makefile usage, and an Ubuntu AppArmor workaround. - Update
.gitignoreto exclude mkosi build outputs underimages/*/.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| images/README.md | Documents image naming/build usage and Ubuntu AppArmor workaround. |
| images/Makefile | Adds Make targets to build/clean/list/status mkosi images by image directory name. |
| .gitignore | Ignores mkosi artifacts produced under images/*/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amanda Liem <aliem@amd.com>
amd-aliem
force-pushed
the
dev-image-build
branch
from
45c4c0e to
dbe4b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small changes to improve dev experience:
Makefile Targets:
make list: show available imagesmake status: show built images and their artifactsmake <image>: build one image (make host-fedora-41)make all: build every imagemake clean-<image>: clean one image (make clean-host-fedora-41)make clean: clean every image